Skip to content

Duplicate APIs that differ only in casing #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pimterry opened this issue Feb 13, 2019 · 6 comments
Open

Duplicate APIs that differ only in casing #542

pimterry opened this issue Feb 13, 2019 · 6 comments
Assignees
Labels

Comments

@pimterry
Copy link
Contributor

Azure.com contains specs for both sql-databases and sql-Databases:

It also has specs for both azsadmin-Quotas and azsadmin-quotas:

Definitely seems like a mistake, and something that might cause unpredictable behaviour in some environments.

(I'm planning to keep filing minor errors I spot like this, partly just for my reference, but do let me know if it's annoying!)

@MikeRalphson
Copy link
Collaborator

Not annoying!

@MikeRalphson
Copy link
Collaborator

Fixed. As this looks like Microsoft manually moving API documents around, and doesn't seem to be a widespread problem, so I'll leave it as a manual fix for now. Thanks for raising the issue.

@pimterry
Copy link
Contributor Author

Amazing, thanks for sorting this.

@pimterry
Copy link
Contributor Author

@MikeRalphson, a user downstream (httptoolkit/openapi-directory-js#20) has just pointed out that this reappeared at some point, and there are now duplicates with different casing for at least Azure.com/azsadmin-quotas and Azure.com/sql-databaseSecurityAlertPolicies:

I haven't done a proper check for other examples, I suspect there may be more! I'm going to update openapi-directory-js shortly, and I'll see if I can automatically spot & flag those there myself, but it might also be worth finding a way to check them here too if possible.

It looks like really these are valid, it's just that they should just be compared case-insensitively so each pair here are treated as specs for the same service, right?

@MikeRalphson
Copy link
Collaborator

MikeRalphson commented Feb 27, 2023

Thanks! On your last point, you're probably right, I just need to check how much work it's going to be.

It's probably come back because I've moved from Linux to a mac.

@pimterry
Copy link
Contributor Author

I haven't done a proper check for other examples, I suspect there may be more!

Just to confirm here, I have now added some checks on my end to catch this, and I think there are only 3 cases currently with casing issues (as opposed to the Googleapis.com issue in #777) and they're all Azure:

Duplicate spec id azure.com/azsadmin-quotas between APIs/azure.com/azsadmin-quotas/2019-08-08-preview/swagger.yaml and APIs/azure.com/azsadmin-Quotas/2018-02-09/swagger.yaml
Duplicate spec id azure.com/sql-databaseSecurityAlertPolicies between APIs/azure.com/sql-databaseSecurityAlertPolicies/2014-04-01/swagger.yaml and APIs/azure.com/sql-DatabaseSecurityAlertPolicies/2018-06-01-preview/swagger.yaml
Duplicate spec id azure.com/sql-serverAzureADAdministrators between APIs/azure.com/sql-serverAzureADAdministrators/2014-04-01/swagger.yaml and APIs/azure.com/sql-ServerAzureADAdministrators/2018-06-01-preview/swagger.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants