fix broken tests

Author: crpietschmann

src/Build5Nines.SharpVector/MemoryVectorDatabaseBase.cs

@@ -9,6 +9,7 @@
 using System.Runtime.CompilerServices;
 using System.Text.Json;
 using Build5Nines.SharpVector.Embeddings;
+using System.Runtime.ExceptionServices;
 
 namespace Build5Nines.SharpVector;
 
@@ -143,8 +144,9 @@ public void UpdateText(TId id, TVocabularyKey text)
     public void UpdateTextMetadata(TId id, TMetadata metadata) {
         if (VectorStore.ContainsKey(id))
         {
-            var text = GetText(id);
-            text.Metadata = metadata;
+            var existing = VectorStore.Get(id);
+            existing.Metadata = metadata;
+            VectorStore.Set(id, existing);
         }
         else
         {
@@ -226,7 +228,7 @@ private async Task<IEnumerable<IVectorTextResultItem<TId, TVocabularyKey, TMetad
         }
 
         var results = new ConcurrentBag<VectorTextResultItem<TId, TVocabularyKey, TMetadata>>();
-        await foreach (var kvp in VectorStore)
+        await foreach (KeyValuePair<TId, VectorTextItem<TVocabularyKey, TMetadata>> kvp in VectorStore)
         {
             var item = kvp.Value;
             float vectorComparisonValue = await _vectorComparer.CalculateAsync(_vectorizer.NormalizeVector(queryVector, desiredLength), _vectorizer.NormalizeVector(item.Vector, desiredLength));
@@ -438,9 +440,10 @@ public async Task UpdateTextAsync(TId id, string text)
     {
         if (VectorStore.ContainsKey(id))
         {
+            var existing = VectorStore.Get(id);
             var vector = await EmbeddingsGenerator.GenerateEmbeddingsAsync(text);
-            var metadata = VectorStore.Get(id).Metadata;
-            VectorStore.Set(id, new VectorTextItem<TMetadata>(text, metadata, vector));
+            var metadata = existing.Metadata;
+            VectorStore.Set(id, new VectorTextItem<TMetadata>(text, existing.Metadata, vector));
         }
         else
         {
@@ -468,8 +471,9 @@ public void UpdateText(TId id, string text)
     public void UpdateTextMetadata(TId id, TMetadata metadata) {
         if (VectorStore.ContainsKey(id))
         {
-            var text = GetText(id);
-            text.Metadata = metadata;
+            var existing = VectorStore.Get(id);
+            existing.Metadata = metadata;
+            VectorStore.Set(id, existing);
         }
         else
         {

src/Build5Nines.SharpVector/VectorTextResultItem.cs

@@ -29,7 +29,7 @@ public class VectorTextResultItem<TId, TDocument, TMetadata>
 
     public VectorTextResultItem(TId id, IVectorTextItem<TDocument, TMetadata> item, float vectorComparison)
     {
-        _id = Id;
+        _id = id;
         _item = item;
         VectorComparison = vectorComparison;
     }

src/SharpVectorTest/VectorDatabaseTests.cs

@@ -26,7 +26,7 @@ public void BasicMemoryVectorDatabase_01()
 
         Assert.AreEqual(1, results.Texts.Count());
         Assert.IsTrue(results.Texts.First().Text.Contains("Lion King"));
-        Assert.AreEqual(0, results.Texts.First().Id);
+        Assert.AreEqual(1, results.Texts.First().Id);
         Assert.AreEqual("[some metadata here]", results.Texts.First().Metadata);
         Assert.AreEqual(0.3396831452846527, results.Texts.First().VectorComparison);
     }
@@ -506,18 +506,19 @@ public async Task SimpleTest_BasicMemoryVectorDatabase_UpdateMetadata_01()
         var item = results.Texts.First();
 
         Assert.AreEqual(2, id);
+        Assert.AreEqual(id, item.Id, "ID should match the one returned by AddText.");
 
         vdb.UpdateTextMetadata(item.Id, "222");
 
         results = await vdb.SearchAsync("Two");
 
-        Assert.AreEqual(1, results.Texts.Count());
+        Assert.AreEqual(3, results.Texts.Count());
         Assert.AreEqual("Two", results.Texts.First().Text);
         Assert.AreEqual("222", results.Texts.First().Metadata);
 
         results = await vdb.SearchAsync("One");
 
-        Assert.AreEqual(1, results.Texts.Count());
+        Assert.AreEqual(3, results.Texts.Count());
         Assert.AreEqual("One", results.Texts.First().Text);
         Assert.AreEqual("1", results.Texts.First().Metadata);
     }
@@ -540,13 +541,13 @@ public async Task SimpleTest_MemoryVectorDatabase_UpdateMetadata_01()
 
         vdb.UpdateTextMetadata(item.Id, "222");
 
-        results = await vdb.SearchAsync("Two");
+        results = await vdb.SearchAsync("Two", pageCount: 1);
 
         Assert.AreEqual(1, results.Texts.Count());
         Assert.AreEqual("Two", results.Texts.First().Text);
         Assert.AreEqual("222", results.Texts.First().Metadata);
 
-        results = await vdb.SearchAsync("One");
+        results = await vdb.SearchAsync("One", pageCount: 1);
 
         Assert.AreEqual(1, results.Texts.Count());
         Assert.AreEqual("One", results.Texts.First().Text);
@@ -567,24 +568,23 @@ public async Task SimpleTest_MemoryVectorDatabase_UpdateMetadata_02()
 
         var results = await vdb.SearchAsync("Two");
 
+        foreach(var i in results.Texts)
+        {
+            Assert.AreNotEqual("00000000-0000-0000-0000-000000000000", i.Id.ToString(), $"Search ID ({i.Text}) should not be empty.");
+        }
+
         var item = results.Texts.First();
 
-        Assert.AreNotEqual("00000000-0000-0000-0000-000000000000", item.Id.ToString(), "Search ID should not be empty.");
+        Assert.AreEqual(id, item.Id, "ID should match the one returned by AddText.");
 
         vdb.UpdateText(item.Id, "TwoTwo");
         vdb.UpdateTextMetadata(item.Id, "222");
 
         results = await vdb.SearchAsync("Two");
 
-        Assert.AreEqual(1, results.Texts.Count());
-        Assert.AreEqual("Two", results.Texts.First().Text);
+        Assert.AreEqual(3, results.Texts.Count());
+        Assert.AreEqual("TwoTwo", results.Texts.First().Text);
         Assert.AreEqual("222", results.Texts.First().Metadata);
-
-        results = await vdb.SearchAsync("One");
-
-        Assert.AreEqual(1, results.Texts.Count());
-        Assert.AreEqual("One", results.Texts.First().Text);
-        Assert.AreEqual("1", results.Texts.First().Metadata);
     }
 
     [TestMethod]
@@ -611,13 +611,6 @@ public void SimpleTest_MemoryVectorDatabase_UpdateMetadata_03()
         Assert.AreEqual("{ value: \"元数据初始值\" }", results.Texts.First().Metadata);
     }
 
-
-
-
-
-
-
-
     [TestMethod]
     public void EuclideanDistanceVectorComparerAsyncMemoryVectorDatabase_1()
     {