Skip to content

The MDL view with invalid SQL will fail the query #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goldmedal opened this issue May 5, 2025 · 1 comment
Closed

The MDL view with invalid SQL will fail the query #1181

goldmedal opened this issue May 5, 2025 · 1 comment
Assignees
Labels
bug Something isn't working core

Comments

@goldmedal
Copy link
Contributor

Description

If the MDL has a view with invalid SQL, the query based on it will fail even if it doesn't use the invalid view.
The problem is that wren_core will plan all the view SQL when analyzing the MDL. So, if any view is invalid, the request will always fail.

Expected behavior

Instead of planning all the views, it's better to plan the views when they're used.

@goldmedal goldmedal added bug Something isn't working core labels May 5, 2025
@goldmedal goldmedal self-assigned this May 9, 2025
@goldmedal
Copy link
Contributor Author

I found that the unused view will be filtered by ManifestExtractor. So, we won't occur this issue when the query through ibis-server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

No branches or pull requests

1 participant