Skip to content

OpenTelemetry instrumentation #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mshustov opened this issue Nov 29, 2024 Discussed in #1267 · 1 comment
Open

OpenTelemetry instrumentation #1444

mshustov opened this issue Nov 29, 2024 Discussed in #1267 · 1 comment

Comments

@mshustov
Copy link
Member

Discussed in #1267

Originally posted by tanenbaum April 9, 2024
Hello!

I was looking at how I might get instrumentation out of the library, both traces and metrics. I noticed that the ch-go "low level" API instruments various code paths, like https://github.com/ClickHouse/ch-go/blob/main/query.go#L609. I did at first think this library used those code paths, but as far as I can tell it is only sharing the driver.Conn interface definition and not using the ch-go client.

Is there any plan to do the same sort of instrumentation in this library? Would you like contributions in this area?

@EpicStep
Copy link
Contributor

Hi, it’s a good idea, but I wouldn't want the library to be use to a specific tracing implementation like opentracing, but to provide an interface like in pgx. (https://pkg.go.dev/github.com/jackc/pgx/v5#QueryTracer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants