[Bug] download_check.blade.php logic issue

[bitappend]

UNIT3D Version

v8.1.3

PHP & Platform

8.0.40-0ubuntu0.24.04.1

Laravel verion

11.5.0

Have you done this?

• I am willing to share my stack trace and logs
• I can suggest a fix as a Pull Request

Expectation

leechers should be able to host a torrent to help themselves out of a ratio issue.

Description

We have found an two different scenarios making it hard to isolate the cause at first... and we kind of passed it off as newbs not knowing what they are doing.

However we ran several A B test to see if we can get a leecher to upload a torrent but also reproduce the catch 22 where they cant.

the issue seems to stem from resources/views/torrent/download_check.blade.php
we did some quick edits around line 74 & 146 to make it at least functional for our users.
However we don't feel the quick edits are the proper changes as we dropped validation completely.
We will have a better look on another day.

Situation A
We found that when visiting torrents pages as a leech, they are prohibited from downloading the .torrent UNLESS its a torrent that they created... ok that is good. but this it only good if the user does not get too frustrated with the upload process and pokes around the site to see if they can get it to work. Those that have done that have worked themselves out of a hole

Situation B
When a person first uploads a torrent they are presented with download_check.blade.php
which looks like the logic is different from the normal torrents page. as this checks if the user meets the ratio requirement regardless if they are the uploader.

1. User sees ratio is too low.
2. User tries uploading to remedy
3. Cant download the torrent file with the announce stamp from the tracker, being told ratio too low.
4. they feel stuck in a catch 22 and eventually give up, abandoning site.

For us we dropped the validation logic as a temp measure to make the link functional.
We did not change the error message as we wanted bare minimum to make this functional.
perhaps leave the security up to the amount of download slots permitted by leech?

Stack trace & logs

[Ummagummbo]

I have to agree here, When someone slips into Leech they can accidentally get trapped there if they can't upload