[Bug] Mismatched torrent counts

[markhc]

I want to preface this by saying I am a mere user, just reporting what I see across a couple trackers.

UNIT3D Version

9.0.1

PHP & Platform

Unknown

Laravel verion

Unknown

Have you done this?

• I am willing to share my stack trace and logs
• I can suggest a fix as a Pull Request

Expectation

I expect the values to be consistent across the different interfaces.

Description

The torrent download count on the profile vs the user dropdown do not match.

I am not certain of this, but I believe the user profile page is somehow counting trumped or deleted torrents. Which seems to be the case from some quick math that I did: Dividing the Total Seedtime by the Average Seedtime as displayed in the user profile gives the Total downloads + Total uploads as displayed in the profile (823 + 49), but my torrent history does not have that many downloads anymore, the torrent history count matches with the count displayed in the user dropdown (718 + 49), which leads me to believe it is counting deleted or trumped torrents in the history.

Stack trace & logs

[Roardom]

The torrent download count on the profile vs the user dropdown do not match.

Thanks for the report. Fixed in #4611

I am not certain of this, but I believe the user profile page is somehow counting trumped or deleted torrents

This is intentional. Related: #4604

[markhc]

I see. It seems a bit counter-productive to have trumped torrents affect your Average seedtime negatively (since they cannot be seeded anymore). This discourages the download of torrents that are likely to be trumped soon, like individual episodes for running series that are likely to get a Season Pack.

Hope to see #4604 implemented soon.

[Roardom]

At the same time, if you've seeded a torrent for 5 years and it gets trumped, you'd hate to lose that torrent bringing your average up. So excluding deleted torrents also hurts users, it's a lose-lose scenario. That's where the benefit of #4604 comes in. I don't plan to implement it immediately, but that's the end goal solution to the issue of trumping affecting the average seedtime.

[markhc]

Yeah that's a very good point, thank you for the explanation. It seems like a good solution indeed.