Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Overhaul Usage of GenerateTables #51

Open
TheCedarPrince opened this issue Mar 20, 2023 · 1 comment
Open

[FEATURE] Overhaul Usage of GenerateTables #51

TheCedarPrince opened this issue Mar 20, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed moderate Issue of moderate difficulty

Comments

@TheCedarPrince
Copy link
Member

GenerateTables() is a rather odd function that I think can be made much more into a utility function that operates in the background. What it does is create for OMOPCDMCohortCreator.jl an internal representation of the tables available within the schema being accessed via a given connection. This internal representation are SQLTable objects that originate within FunSQL.

I think what we can do instead is to add OMOPCommonDataModel as a dependency. From there, we can access and export every single table from that package and within CohortCreator, convert the table structs within OMOPCommonDataModel to FunSQL tables. This could be triggered during the GenerateDatabaseDetails function.

Additionally, we can keep this function in case someone needs to modify further the table connection.

@TheCedarPrince TheCedarPrince added enhancement New feature or request help wanted Extra attention is needed moderate Issue of moderate difficulty labels Mar 20, 2023
@TheCedarPrince
Copy link
Member Author

It also just dawned on me that we will want to add OMOPCommonDataModel as a conditional dependency as well -- this will be somewhat tricky and may need to be a second issue altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed moderate Issue of moderate difficulty
Projects
None yet
Development

No branches or pull requests

1 participant