Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Modify Arithmetic notations in all the docstrings. #64

Open
Jay-sanjay opened this issue Nov 18, 2023 · 0 comments
Open

[DOCS] Modify Arithmetic notations in all the docstrings. #64

Jay-sanjay opened this issue Nov 18, 2023 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation good for beginners

Comments

@Jay-sanjay
Copy link
Member

Jay-sanjay commented Nov 18, 2023

The reason why earlier "Integer" being mentioned in the OMOP CDM, is that we will not have cohorts or subject id's that are say, "1.5" or something like that. But yes, it is fair to have "1.0" as a float value but it should really be an integer in that case.

Yet, we think it is best to not say Integer but rather Float to prevent confusion if in-case someone wonders - why "1" might work for a cohort ID when "1.0" does not.
cc @TheCedarPrince Thanks :)

@TheCedarPrince TheCedarPrince added documentation Improvements or additions to documentation good for beginners labels Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good for beginners
Projects
None yet
Development

No branches or pull requests

2 participants