Graceful handling for invalid target function #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Me too, I may need some time to confirm. |
m417z
added a commit
to m417z/minhook-detours
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14.
Note that this fix is not 100% complete. For example, the x64 command
FF 01is valid, butFF FFisn't. Still, both are reported as 2-byte commands.I'm not an assembly guru, but this comment:
KNSoft.SlimDetours/Source/SlimDetours/Disassembler.c
Line 1490 in 4cc236a
Makes me think that perhaps a check like
if (b1 & 0x80) return NULL;if ((b1 & 0x38) == 0x38) return NULL;) will cover this case and similar cases where this comment is found.I don't know if other adjustments are required, and I didn't want to make changes in these sensitive areas which I don't fully understand.