Skip to content

Sync primitives arch screwup #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pikachuxxxx opened this issue Feb 11, 2025 · 0 comments
Open

Sync primitives arch screwup #398

Pikachuxxxx opened this issue Feb 11, 2025 · 0 comments
Labels
Architecture Issues related to API/ Engine design and architecture. bug Something isn't working good first issue Good for newcomers
Milestone
V.1.0.0.RC

Comments

@Pikachuxxxx
Copy link
Owner

Pikachuxxxx commented Feb 11, 2025 •
edited
Loading

remove FrameSyncData_VK vkswapchain.h and let it be managed wither by RHI similar to how DX12RenderContext works or use DianaRenderer to manage this and Light/Frame descriptor sets.

We also currently have 3 frame in flight --> make it 2 and simply command buffer usage using ring buffers

Also use fences + semaphore for vulkan and just fences and uint64_t value for all other APIs (DX12, consoles etc.)
@Pikachuxxxx Pikachuxxxx added Architecture Issues related to API/ Engine design and architecture. good first issue Good for newcomers labels Feb 11, 2025
@Pikachuxxxx Pikachuxxxx added this to the V.1.0.0.RC milestone Feb 11, 2025
@Pikachuxxxx Pikachuxxxx added the bug Something isn't working label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Architecture Issues related to API/ Engine design and architecture. bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
V.1.0.0.RC
Development

No branches or pull requests
1 participant
@Pikachuxxxx