-
Notifications
You must be signed in to change notification settings - Fork 41
Feedback on moving from extra_state_attributes to sensors. #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Really nice work. I think it would definitely make the component more future proof! Also it makes access to the different attributes as sensors a lot nicer than using templates. Maybe a next step would be to make a PR and iterate in there, or put it on a branch here, so we can make a beta release at least. |
Yeah, individual sensors would be awesome. |
this is nice. hope it will be merged soon. |
@TimSoethout created a PR from this: #91 |
I have been working on a branch which exposes API data as Sensors rather then extra_state_attributes on the inverter entity.
Is allows us to tell home assistant about the types of the attributes.
Here's where I currently stand in this development https://github.com/L-four/goodwe-sems-home-assistant/blob/master/custom_components/sems/sensor.py
I would like to gauge interest merging this change and gathering feedback on these changes.
Screenshots:
The text was updated successfully, but these errors were encountered: