Skip to content

Feedback on moving from extra_state_attributes to sensors. #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
L-four opened this issue Oct 21, 2023 · 4 comments
Open

Feedback on moving from extra_state_attributes to sensors. #89

L-four opened this issue Oct 21, 2023 · 4 comments

Comments

@L-four
Copy link

L-four commented Oct 21, 2023

I have been working on a branch which exposes API data as Sensors rather then extra_state_attributes on the inverter entity.
Is allows us to tell home assistant about the types of the attributes.

Here's where I currently stand in this development https://github.com/L-four/goodwe-sems-home-assistant/blob/master/custom_components/sems/sensor.py

I would like to gauge interest merging this change and gathering feedback on these changes.

Screenshots:

image image
@TimSoethout
Copy link
Owner

Really nice work. I think it would definitely make the component more future proof! Also it makes access to the different attributes as sensors a lot nicer than using templates.

Maybe a next step would be to make a PR and iterate in there, or put it on a branch here, so we can make a beta release at least.

@f00f
Copy link

f00f commented Oct 31, 2023

Yeah, individual sensors would be awesome.
I'm a noob with HA, but I could help with testing this anyways - if someone tells me how to install a dev branch of this integration.

@robinhood-code
Copy link

this is nice. hope it will be merged soon.

@f00f
Copy link

f00f commented Nov 6, 2023

@TimSoethout created a PR from this: #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants