fix: fix clippy issue after rust update to 1.8.7 (#1262)

`large-error-threshold` is the changed clippy option
which makes noise.
ballista controlled code has been fixed to address
it, new `clippy.toml` rule has been added to disable
check util we update to datafusion 48 where it will
be fixed for datafusion related code.

Author: milenkovicm

ballista/core/src/error.rs

@@ -39,11 +39,11 @@ pub enum BallistaError {
     Internal(String),
     Configuration(String),
     ArrowError(ArrowError),
-    DataFusionError(DataFusionError),
+    DataFusionError(Box<DataFusionError>),
     SqlError(parser::ParserError),
     IoError(io::Error),
     TonicError(tonic::transport::Error),
-    GrpcError(tonic::Status),
+    GrpcError(Box<tonic::Status>),
     GrpcConnectionError(String),
     TokioError(tokio::task::JoinError),
     GrpcActionError(String),
@@ -80,7 +80,9 @@ impl From<ArrowError> for BallistaError {
             ArrowError::ExternalError(e)
                 if e.downcast_ref::<DataFusionError>().is_some() =>
             {
-                BallistaError::DataFusionError(*e.downcast::<DataFusionError>().unwrap())
+                BallistaError::DataFusionError(Box::new(
+                    *e.downcast::<DataFusionError>().unwrap(),
+                ))
             }
             other => BallistaError::ArrowError(other),
         }
@@ -97,7 +99,7 @@ impl From<DataFusionError> for BallistaError {
     fn from(e: DataFusionError) -> Self {
         match e {
             DataFusionError::ArrowError(e, _) => Self::from(e),
-            _ => BallistaError::DataFusionError(e),
+            _ => BallistaError::DataFusionError(Box::new(e)),
         }
     }
 }
@@ -116,7 +118,7 @@ impl From<tonic::transport::Error> for BallistaError {
 
 impl From<tonic::Status> for BallistaError {
     fn from(e: tonic::Status) -> Self {
-        BallistaError::GrpcError(e)
+        BallistaError::GrpcError(Box::new(e))
     }
 }
 
@@ -216,9 +218,11 @@ impl From<BallistaError> for FailedTask {
                     failed_reason: Some(FailedReason::IoError(IoError {})),
                 }
             }
-            BallistaError::DataFusionError(DataFusionError::IoError(io)) => {
+            BallistaError::DataFusionError(e)
+                if matches!(*e, DataFusionError::IoError(_)) =>
+            {
                 FailedTask {
-                    error: format!("Task failed due to DataFusion IO error: {io:?}"),
+                    error: format!("Task failed due to DataFusion IO error: {e:?}"),
                     // IO error is considered to be temporary and retryable
                     retryable: true,
                     count_to_failures: true,

ballista/core/src/serde/scheduler/from_proto.rs

@@ -426,5 +426,5 @@ fn reset_metrics_for_execution_plan(
         plan.with_new_children(children).map(Transformed::yes)
     })
     .data()
-    .map_err(BallistaError::DataFusionError)
+    .map_err(|e| BallistaError::DataFusionError(Box::new(e)))
 }

clippy.toml

@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# increasing the threshold until we get to datafusion 48 which should
+# address this issue. 
+#
+# https://github.com/apache/datafusion/pull/15861
+large-error-threshold = 266