Warn if memory pool is dropped with bytes still reserved (#1721)

andygrove · web-flow · commit c6d615714efc · 2025-05-08T07:55:24.000-06:00
diff --git a/native/core/src/execution/memory_pools/unified_pool.rs b/native/core/src/execution/memory_pools/unified_pool.rs
@@ -76,6 +76,15 @@ impl CometMemoryPool {
     }
 }
 
+impl Drop for CometMemoryPool {
+    fn drop(&mut self) {
+        let used = self.used.load(Relaxed);
+        if used != 0 {
+            log::warn!("CometMemoryPool dropped with {} bytes still reserved", used);
+        }
+    }
+}
+
 unsafe impl Send for CometMemoryPool {}
 unsafe impl Sync for CometMemoryPool {}
 

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,15 @@ impl CometMemoryPool {`
`76`	`76`	`}`
`77`	`77`	`}`
`78`	`78`
	`79`	`+impl Drop for CometMemoryPool {`
	`80`	`+ fn drop(&mut self) {`
	`81`	`+ let used = self.used.load(Relaxed);`
	`82`	`+ if used != 0 {`
	`83`	`+ log::warn!("CometMemoryPool dropped with {} bytes still reserved", used);`
	`84`	`+ }`
	`85`	`+ }`
	`86`	`+}`
	`87`	`+`
`79`	`88`	`unsafe impl Send for CometMemoryPool {}`
`80`	`89`	`unsafe impl Sync for CometMemoryPool {}`
`81`	`90`