Skip to content

Commit dcce4e3

Browse files
authored
chore: Run Comet tests for more Spark versions (#1582)
## Which issue does this PR close? Closes #1579 ## Rationale for this change Run Comet tests for 3.5.2 through 3.5.4 to avoid introducing regressions for those releases
1 parent 4110bcd commit dcce4e3

File tree

2 files changed

+43
-2
lines changed

2 files changed

+43
-2
lines changed

.github/workflows/pr_build.yml

+37
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ env:
4040
RUST_VERSION: stable
4141

4242
jobs:
43+
44+
# run Comet test with full matrix of Java and Scala versions for the latest supported 3.5.x release
4345
linux-test:
4446
strategy:
4547
matrix:
@@ -76,6 +78,41 @@ jobs:
7678
# upload test reports only for java 17
7779
upload-test-reports: ${{ matrix.java_version == '17' }}
7880

81+
# run Comet tests for older 3.5.x releases with one java and scala versions
82+
linux-test-35-minor-versions:
83+
strategy:
84+
matrix:
85+
os: [ubuntu-latest]
86+
java_version: [17]
87+
test-target: [java]
88+
spark-version: ['3.5']
89+
spark-patch-version: ['3.5.2', '3.5.3', '3.5.4']
90+
scala-version: ['2.12']
91+
is_push_event:
92+
- ${{ github.event_name == 'push' }}
93+
fail-fast: false
94+
name: ${{ matrix.os }}/java ${{ matrix.java_version }}-spark-${{matrix.spark-patch-version}}-scala-${{matrix.scala-version}}/${{ matrix.test-target }}
95+
runs-on: ${{ matrix.os }}
96+
container:
97+
image: amd64/rust
98+
steps:
99+
- uses: actions/checkout@v4
100+
- name: Setup Rust & Java toolchain
101+
uses: ./.github/actions/setup-builder
102+
with:
103+
rust-version: ${{env.RUST_VERSION}}
104+
jdk-version: ${{ matrix.java_version }}
105+
- if: matrix.test-target == 'rust'
106+
name: Rust test steps
107+
uses: ./.github/actions/rust-test
108+
- if: matrix.test-target == 'java'
109+
name: Java test steps
110+
uses: ./.github/actions/java-test
111+
with:
112+
maven_opts: "-Pspark-${{ matrix.spark-version }},scala-${{ matrix.scala-version }} -Dspark.version=${{ matrix.spark-patch-version }}"
113+
# upload test reports only for java 17
114+
upload-test-reports: ${{ matrix.java_version == '17' }}
115+
79116
linux-test-native-datafusion-scan:
80117
strategy:
81118
matrix:

docs/source/user-guide/installation.md

+6-2
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,15 @@ We recommend only using Comet with Spark versions where we currently have both C
3838
Other versions may work well enough for development and evaluation purposes.
3939

4040
| Spark Version | Java Version | Scala Version | Comet Tests in CI | Spark Tests in CI |
41-
| ------------- | ------------ | ------------- | ----------------- | ----------------- |
41+
| ------------- | ------------ | ------------- |-------------------| ----------------- |
4242
| 3.4.3 | 8/11/17 | 2.12/2.13 | Yes | Yes |
43-
| 3.5.4 | 8/11/17 | 2.12/2.13 | No | Yes |
43+
| 3.5.2 | 8/11/17 | 2.12/2.13 | Partial\* | No |
44+
| 3.5.3 | 8/11/17 | 2.12/2.13 | Partial\* | No |
45+
| 3.5.4 | 8/11/17 | 2.12/2.13 | Partial\* | Yes |
4446
| 3.5.5 | 8/11/17 | 2.12/2.13 | Yes | Yes |
4547

48+
\* For older Spark 3.5.x releases, we do not test the full matrix of supported Java and Scala versions in CI.
49+
4650
Experimental support is provided for the following versions of Apache Spark and is intended for development/testing
4751
use only and should not be used in production yet.
4852

0 commit comments

Comments
 (0)