Skip to content

Analyzers for proper TokenStream inheritance usage #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
paulirwin opened this issue Mar 17, 2025 · 0 comments
Open
1 task done

Analyzers for proper TokenStream inheritance usage #1146

paulirwin opened this issue Mar 17, 2025 · 0 comments
Labels
analyzers approved-rule is:feature pri:normal up-for-grabs This issue is open to be worked on by anyone
Milestone
4.8.0-beta00018

Comments

@paulirwin
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

No response

Describe the solution you'd like

Split out from #271

We should create public (aka not dev) Roslyn analyzers to ensure the TokenStream contract rules are satisfied, particularly around ensuring that you override End, and that if you override End, Reset, or Close, that you call the base method.

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzers approved-rule is:feature pri:normal up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Milestone
4.8.0-beta00018
Development

No branches or pull requests
1 participant
@paulirwin