Skip to content

Jar artifacts should use "cleanup" LICENSE and NOTICE #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jbonofre opened this issue Mar 27, 2025 · 7 comments
Open

Jar artifacts should use "cleanup" LICENSE and NOTICE #1270

jbonofre opened this issue Mar 27, 2025 · 7 comments
Assignees
@jbonofre
Labels
bug Something isn't working
Milestone
0.10.0-beta

Comments

@jbonofre
Copy link
Member

jbonofre commented Mar 27, 2025 •
edited
Loading

The NOTICE and LICENSE in the distributed jar (on Maven) are using the ones from the source distribution.
If it's acceptable, it's not accurate.
I'm working on improving this.
@jbonofre jbonofre added the bug Something isn't working label Mar 27, 2025
@jbonofre jbonofre self-assigned this Mar 27, 2025
@jbonofre jbonofre added this to the 0.10.0-beta milestone Mar 27, 2025
@snazy
Copy link
Member

snazy commented Mar 27, 2025

./gradlew :polaris-version:pTML -PjarWithGitInfo or ./gradlew ... -Prelease ?

unzip -l ~/.m2/repository/org/apache/polaris/polaris-version/1.0.0-incubating-SNAPSHOT/polaris-version-1.0.0-incubating-SNAPSHOT.jar 
incubating-SNAPSHOT.jar
  Length      Date    Time    Name
---------  ---------- -----   ----
        0  2025-03-27 18:54   META-INF/
      679  2025-03-27 18:54   META-INF/MANIFEST.MF
        0  2025-03-27 11:32   org/
        0  2025-03-27 11:32   org/apache/
        0  2025-03-27 11:32   org/apache/polaris/
        0  2025-03-27 11:32   org/apache/polaris/version/
     5085  2025-03-27 11:32   org/apache/polaris/version/PolarisVersion$PolarisVersionJarInfo.class
        0  2025-03-27 18:54   META-INF/licenses/
        0  2025-03-27 18:54   META-INF/licenses/org.apache.polaris/
        0  2025-03-27 18:54   META-INF/licenses/org.apache.polaris/polaris-version-1.0.0-incubating-SNAPSHOT/
      305  2025-03-27 18:54   META-INF/licenses/org.apache.polaris/polaris-version-1.0.0-incubating-SNAPSHOT/NOTICE
    17356  2025-03-27 18:54   META-INF/licenses/org.apache.polaris/polaris-version-1.0.0-incubating-SNAPSHOT/LICENSE
        0  2025-03-27 18:54   META-INF/maven/
        0  2025-03-27 18:54   META-INF/maven/org.apache.polaris/
        0  2025-03-27 18:54   META-INF/maven/org.apache.polaris/polaris-version/
     2480  2025-03-27 18:54   META-INF/maven/org.apache.polaris/polaris-version/pom.xml
      128  2025-03-27 18:54   META-INF/maven/org.apache.polaris/polaris-version/pom.properties

@jbonofre
Copy link
Member Author

I'm using -PjarWithGitInfo (-Prelease requires a git tag).

Let me try again.

@snazy
Copy link
Member

snazy commented Mar 27, 2025

Or try the following from #485

release/bin/draft-release.sh --major 0 --minor 10 --label beta --dry-run --keep-release-worktree

(for options see release/bin/draft-release.sh -h)

@snazy
Copy link
Member

snazy commented Mar 27, 2025

(Just note that #485 creates a Git worktree in the root directory's build/ directory so it can do the Git dance there)

@jbonofre jbonofre changed the title Jar artifacts published on Maven doesn't include LICENSE/NOTICE Jar artifacts should use "cleanup" LICENSE and NOTICE Mar 27, 2025
@jbonofre
Copy link
Member Author

@snazy sorry for the noise, it was a typo. It works. I'm checking the LICENSE and NOTICE content.

@snazy
Copy link
Member

snazy commented Mar 27, 2025

Mind closing this one then?

@jbonofre
Copy link
Member Author

I changed the purpose of this issue (for me). I'm working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbonofre jbonofre

Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.0-beta
Development

No branches or pull requests
2 participants
@jbonofre @snazy