Skip to content

Add chrome option for PlaywrightCrawler #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pijukatel opened this issue Mar 11, 2025 · 2 comments
Open

Add chrome option for PlaywrightCrawler #1071

Pijukatel opened this issue Mar 11, 2025 · 2 comments
Assignees
@Pijukatel
Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@Pijukatel
Copy link
Collaborator

Pijukatel commented Mar 11, 2025 •
edited
Loading

Currently when using PlaywrightCrawler the three default browser types are 'chromium', 'firefox', 'webkit'

Add straight forward support for actual Chrome as well. (consider if that is supposed to be in the same optional group as playwright or even addtional optional group as it will require download and installation of Chrome browser as well)
@Pijukatel Pijukatel added enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team. labels Mar 11, 2025
@Mantisus
Copy link
Collaborator

But Chrome is a channel not a browser_type.

It is already supported if Chrome browser is installed on the system and pass the appropriate parameter to the browser_launch_options

@Pijukatel
Copy link
Collaborator Author

But Chrome is a channel not a browser_type.

It is already supported if Chrome browser is installed on the system and pass the appropriate parameter to the browser_launch_options

@B4nan best if you answer this question. No point in me being the middleman. What exactly was your idea for "chrome support"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pijukatel Pijukatel

Labels
enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mantisus @Pijukatel