-
Notifications
You must be signed in to change notification settings - Fork 379
Breaking changes for v0.6 #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Regarding abstract class naming, just one more thing to think about. It will involve both BaseSomeClass and AbstractSomeClass. What will we do when we have default implementation of such class? For example HttpCrawler is one implementation of AbstractHttpCrawler. (Where HttpCrawler was reserved for backwards compatibility) |
Maybe for |
I'm thinking of moving from a |
One more thing from Ruff 0.9:
Since |
I wouldn't mind disabling the rule in this case. It is unlikely that anyone will do |
Closing, as all the breaking changes were resolved. (There are no breaking changes in #1024.) |
Remove unused fields in the
Configuration
chrome_executable_path
,xvfb
.verbose_log
field:verbose_log
field is only used to derive the log level, and alog_level
option already exists. So I consider it as redundant.Refactor abstract class naming
BaseStorage
,BaseStorageClient
, ...).Renameenqueue_links
for clarityThe naming ofenqueue_links
causes confusion due to its similarity toadd_requests
.Proposed solution:Renameenqueue_links
to something more descriptive, such asextract_links
(indicating what it does more precisely).I am open to name suggestions here.Update of
enqueue_links
enqueue_links
will have the same interface as its JavaScript counterpart, enqueueLinks.add_requests
will remain dedicated to adding requests to the RQ only.extract_links
function can be introduced for link extraction only.enqueue_links
can utilize bothadd_requests
andextract_links
.The text was updated successfully, but these errors were encountered: