-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer compatible with Node < 16 since upgrade to foreground-child > 3.x #520
Comments
@webketje would you be able to contribute a failing test? our test matrix includes Node 14 and 16 and I haven't been seeing failures. |
I think the test I ran has all the details, but it was run with 14.14.0. According to this article: https://2ality.com/2021/12/node-protocol-imports.html#support-for-node%3A-imports, the |
@bcoe I've done a 2 local test runs with 14.14.0 and 14.18.0 and can confirm that c8 works with Node |
@webketje 👍 sounds like a good call to me. |
All technical details of the test can be found at https://github.com/metalsmith/metalsmith/actions/runs/7854693798/job/21435716699
Since v3.x the dependency
foreground-child
uses thenode:
prefix to include constants and due to this c8 throws in Node < 16:Shall preferably be tackled after a solution is chosen at tapjs/foreground-child#56
The text was updated successfully, but these errors were encountered: