Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish new version with the module entry in package.json #51

Open
kristoferjoseph opened this issue May 9, 2024 · 2 comments
Open

Comments

@kristoferjoseph
Copy link

kristoferjoseph commented May 9, 2024

The currently published version 0.3.0 omits the module entry in package.json that was added recently.
Thank you kindly.

@eloyesp
Copy link

eloyesp commented Aug 9, 2024

Also, it would be nice to export Idiomorph instead of {Idiomorph}.

That is: https://github.com/bigskysoftware/idiomorph/blob/main/package.json#L25 should read

     "esm" : "(cat src/idiomorph.js && echo \"\nexport Idiomorph;\") > dist/idiomorph.esm.js",

That way, the ESM usage would be:

import {default, morph} from 'idiomorph'

@pbowyer
Copy link

pbowyer commented Oct 21, 2024

export Idiomorph;

errors when I test it.

To make this work I had to change the export to:

export const {defaults, morph} = Idiomorph;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants