Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cockpit runtime instance modification batch operation includes all instances #4910

Open
1 task
danielkelemen opened this issue Jan 27, 2025 · 0 comments
Open
1 task
Assignees
Labels
potential:7.22.3 type:bug Issues that describe a user-facing bug in the project.

Comments

@danielkelemen
Copy link
Member

danielkelemen commented Jan 27, 2025

Environment (Required on creation)

Version 7.22, any environment.

Description (Required on creation; please attach any relevant screenshots, stacktraces, log files, etc. to the ticket)

When running an async runtime modification (see steps) the batch job is executed for all instances, including finished and unfinished ones, which is not correct and not what is displayed in the Cockpit migration popup.

Steps to reproduce (Required on creation)

  1. Create process definition. You can put a start event, a user task, and an end event.
  2. Start like 5 PI-s. Complete 3 PI-s by assigning the task and completing it
  3. For the remaining 2 PI-s go to the modify tab, drag and drop the token from the USER TASK to the end event
  4. Go to Select Instances button, and click the Query radio
  5. Remove the filter criteria "Activity_ID=..."
  6. You will see the "Modify all Instances in filter (2)" button, click on it
  7. Leave the async checkbox enabled, you can still see the label under Summary: "You are about to modify 2 instances in the following way:"
    So we are expected to modify only 2 queries
  8. Click proceed
  9. Go to batches page: You will see in the "In Progress Batch Details" that the totalJobs count is 5

Observed Behavior (Required on creation)

Batch runs for all the 5 instances, including finished & unfinished.

Expected behavior (Required on creation)

Batch runs only for the 2 unfinished instances, as it was shown in the popup.

Root Cause (Required on prioritization)

With #4586 we replaced the query with historic query. During the modification popup, the list and count display instances with the unfinished: true parameter, which is correct.
However, for the actual batch query we don't include this property anymore.

Solution Ideas

Use the unfinished: true in the batch modification, too.

Hints

Links

Breakdown

Pull Requests

Preview Give feedback

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@danielkelemen danielkelemen added the type:bug Issues that describe a user-facing bug in the project. label Jan 27, 2025
@venetrius venetrius assigned joaquinfelici and unassigned venetrius Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential:7.22.3 type:bug Issues that describe a user-facing bug in the project.
Projects
None yet
Development

No branches or pull requests

4 participants