Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executable flag in selectJobByQueryCriteriaSql #4933

Open
1 task
prajwolbhandari1 opened this issue Feb 10, 2025 · 0 comments
Open
1 task

Executable flag in selectJobByQueryCriteriaSql #4933

prajwolbhandari1 opened this issue Feb 10, 2025 · 0 comments
Labels
type:bug Issues that describe a user-facing bug in the project.

Comments

@prajwolbhandari1
Copy link
Contributor

prajwolbhandari1 commented Feb 10, 2025

Environment (Required on creation)

reproduced on develop & 7.22

Description (Required on creation; please attach any relevant screenshots, stacktraces, log files, etc. to the ticket)

​​​​In job.xml it is implemented like this:

Image

In docs:

Image

Steps to reproduce (Required on creation)

job.xml -> selectJobByQueryCriteriaSql -> flag

Observed Behavior (Required on creation)

The executable filter excludes jobs tied to a suspended process instance but does not exclude suspended jobs. The documentation doesn't cover either scenario (look above as part of the screenshot).

Expected behavior (Required on creation)

It looks like it should exclude both process instances that are suspended (it already does) and also should exclude jobs that are suspended.

Solution Ideas

replace this:

and (RES.RETRIES_ > 0)
and (RES.DUEDATE_ is null or RES.DUEDATE_ <= #{now, jdbcType=TIMESTAMP})
and (
(RES.EXECUTION_ID_ is null)
or
(PI.SUSPENSION_STATE_ = 1 or PI.SUSPENSION_STATE_ is null)
)

to:

and (RES.RETRIES_ > 0) and (RES.DUEDATE_ is null or RES.DUEDATE_ <= #{now, jdbcType=TIMESTAMP}) and ( (RES.EXECUTION_ID_ is null) or (PI.SUSPENSION_STATE_ = 1 or PI.SUSPENSION_STATE_ is null) ) _and RES.SUSPENSION_STATE_ = 1_

Hints

Links

Breakdown

Pull Requests

Preview Give feedback
No tasks being tracked yet.

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@prajwolbhandari1 prajwolbhandari1 added the type:bug Issues that describe a user-facing bug in the project. label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Issues that describe a user-facing bug in the project.
Projects
None yet
Development

No branches or pull requests

1 participant