Skip to content

Commit c49990e

Browse files
committed
Prepare fix for debug value defaults for Firefox and Safari, update version to 1.0.8
1 parent c007f24 commit c49990e

File tree

6 files changed

+8
-25
lines changed

6 files changed

+8
-25
lines changed

Extension/Action.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class Action {
5050
if (this.config.timeout != null) {
5151
return this.config.timeout;
5252
} else {
53-
let pipEnabled = ConsentEngine.debugValues.skipHideMethod === false && ConsentEngine.debugValues.hideInsteadOfPIP === false;
53+
let pipEnabled = !(ConsentEngine.debugValues.skipHideMethod || ConsentEngine.debugValues.hideInsteadOfPIP);
5454

5555
if (ConsentEngine.debugValues.clickDelay) {
5656
return 125;
@@ -437,7 +437,7 @@ class HideAction extends Action {
437437
}
438438

439439
async execute(param) {
440-
if(ConsentEngine.debugValues.skipHideMethod === true) {
440+
if(ConsentEngine.debugValues.skipHideMethod) {
441441
return;
442442
}
443443

Extension/ConsentEngine.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ class ConsentEngine {
150150
console.groupEnd();
151151
}
152152
if (!ConsentEngine.debugValues.skipHideMethod) {
153-
if(ConsentEngine.debugValues.dontHideProgressDialog === false) {
153+
if(!ConsentEngine.debugValues.dontHideProgressDialog) {
154154
cmp.stopObservers();
155155
}
156156
}
@@ -234,7 +234,7 @@ class ConsentEngine {
234234
console.log("Error during consent handling:", e);
235235
}
236236
if (!ConsentEngine.debugValues.skipHideMethod) {
237-
if(ConsentEngine.debugValues.dontHideProgressDialog === false) {
237+
if(!ConsentEngine.debugValues.dontHideProgressDialog) {
238238
self.currentCMP = null;
239239
cmp.stopObservers();
240240
cmp.unHideAll();

Extension/GDPRConfig.js

+1-18
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class GDPRConfig {
3535
static getDebugValues() {
3636
return new Promise((resolve, reject) => {
3737
chrome.storage.sync.get({
38-
debugFlags: GDPRConfig.defaultDebugFlags
38+
debugFlags: {}
3939
}, (result) => {
4040
resolve(result.debugFlags);
4141
});
@@ -254,8 +254,6 @@ class GDPRConfig {
254254

255255
static setDebugFlags(newDebugFlags) {
256256
return new Promise((resolve, reject)=>{
257-
newDebugFlags = Object.assign({}, GDPRConfig.defaultDebugFlags, newDebugFlags);
258-
259257
chrome.storage.sync.set({
260258
debugFlags: newDebugFlags
261259
}, () => {
@@ -287,18 +285,3 @@ GDPRConfig.defaultValues = {
287285
GDPRConfig.defaultRuleLists = [
288286
"https://raw.githubusercontent.com/cavi-au/Consent-O-Matic/master/rules-list.json",
289287
];
290-
291-
292-
GDPRConfig.defaultDebugFlags = {
293-
"clickDelay": false,
294-
"skipSubmit": false,
295-
"paintMatchers": false,
296-
"debugClicks": false,
297-
"alwaysForceRulesUpdate": false,
298-
"skipHideMethod": false,
299-
"debugLog": false,
300-
"debugTranslations": false,
301-
"skipSubmitConfirmation": false,
302-
"hideInsteadOfPIP": false,
303-
"dontHideProgressDialog": false
304-
}

Extension/language.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1162,7 +1162,7 @@ class Language {
11621162
} else {
11631163
console.warn("Missing translation ["+lang+"] for key: ", key, translation);
11641164

1165-
if(Language.debugTranslations !== true) {
1165+
if(!Language.debugTranslations) {
11661166
if(translation["en"] != null) {
11671167
result = translation["en"];
11681168
}

Extension/manifest.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"description": "Automatic handling of GDPR consent forms",
44
"author": "CAVI - Aarhus University",
55
"homepage_url": "https://github.com/cavi-au/Consent-O-Matic",
6-
"version": "1.0.5",
6+
"version": "1.0.8",
77
"manifest_version": 2,
88
"permissions": [
99
"activeTab",

Extension/options.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ GDPRConfig.getDebugFlags().then((debugFlags) => {
6161
console.log("Nuking values");
6262
chrome.storage.sync.remove("debugFlags", ()=>{
6363
chrome.storage.sync.set({
64-
debugFlags: {ost:true}
64+
debugFlags: {}
6565
});
6666
setTimeout(async ()=>{
6767
let values = await GDPRConfig.getDebugValues();

0 commit comments

Comments
 (0)