Skip to content

Major bug: equality comparison for rows is broken in latest master #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kazimuth opened this issue May 5, 2025 · 1 comment · Fixed by #316
Closed

Major bug: equality comparison for rows is broken in latest master #313

kazimuth opened this issue May 5, 2025 · 1 comment · Fixed by #316
Assignees
@kazimuth
Labels
bug Something isn't working

Comments

@kazimuth
Copy link
Contributor

kazimuth commented May 5, 2025

Current master should not be released until this is fixed.

The specific issue is that BSATN.Codegen generates incorrect Equals implementations for types containing lists. This did not matter until a75a552, since before that PR whole-row .Equals was not used; rows were instead compared by the equality on their serialization to byte arrays. This needs to be fixed in SpacetimeDB with a change to BSATN.Codegen, followed by a PR here to update the DLLs.
@kazimuth kazimuth added the bug Something isn't working label May 5, 2025
@kazimuth kazimuth self-assigned this May 5, 2025
@kazimuth kazimuth mentioned this issue May 6, 2025
Merged
4 tasks
@joshua-spacetime joshua-spacetime linked a pull request May 12, 2025 that will close this issue
Fix list equals #316
Merged
2 tasks
@joshua-spacetime
Copy link
Contributor

Closed by #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazimuth kazimuth

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix list equals clockworklabs/com.clockworklabs.spacetimedbsdk
2 participants
@kazimuth @joshua-spacetime