-
-
Notifications
You must be signed in to change notification settings - Fork 60
Rule operation-description now requires both a description AND a summary? #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yeah, this is me being pedantic, what is the point of a linter if you don't put both in? they are used differently by different tools. It's also a good point for me to update the docs to change that OR to an AND |
I personnaly think that the old rule was better (to warn only if both are missing), but I see your point. By curiosity, is there any listing or examples of things that could go wrong if either is missing? Which tools might require both, or at least a description, or at least a summary? The main problem I have is that the rule to require BOTH is hardcoded in the go function, so I could not find an easy way to change that behavior from the configurations (but I admit I'm didn't spend much time trying to go deeper than justenabling/disabling pre-built rules). In my case, this reduces the attractiveness of using vacuum for validating internal APIs or as PR requirements. Maybe there could be three rules instead: |
Or alternatively, maybe just adding a new optional |
On v0.16.5 (and probably since #475), the
operation-description
rule fires a warning if an operation object doesn't have a description, even if it has a valid summary.In fact, it also triggers if the operation contains a valid
description
, but nosummary
, saying that "operation [...] is missing a summary".I'm not sure if behavior is intended or not (it goes contrary to the logic decided in #174), but it doesn't match the rule's description that is linked in the reports:
The text was updated successfully, but these errors were encountered: