You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 10, 2025. It is now read-only.
If the current behavior is a bug, please provide the exact steps to reproduce.
What is the expected behavior?
Additional context
Add any other context about the problem here.
The methods buildMap(), start(), uploadImage() use new Promise, although Promise.all() returns a Promise anyway.
For example, in start():
return new Promise(async (resolve) => {
const assets = await Promise.all(this.loadAssets());
resolve(assets);
});
The text was updated successfully, but these errors were encountered:
AndriySymon
changed the title
Suboptimal use of Promise
Suboptimal use of Promise in client.js
Jan 27, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What is the current behavior?
If the current behavior is a bug, please provide the exact steps to reproduce.
What is the expected behavior?
Additional context
Add any other context about the problem here.
The methods buildMap(), start(), uploadImage() use new Promise, although Promise.all() returns a Promise anyway.
For example, in start():
return new Promise(async (resolve) => {
const assets = await Promise.all(this.loadAssets());
resolve(assets);
});
The text was updated successfully, but these errors were encountered: