Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Suboptimal use of Promise in client.js #257

Open
AndriySymon opened this issue Jan 27, 2025 · 0 comments
Open

Suboptimal use of Promise in client.js #257

AndriySymon opened this issue Jan 27, 2025 · 0 comments

Comments

@AndriySymon
Copy link

What is the current behavior?

If the current behavior is a bug, please provide the exact steps to reproduce.

What is the expected behavior?

Additional context
Add any other context about the problem here.

The methods buildMap(), start(), uploadImage() use new Promise, although Promise.all() returns a Promise anyway.
For example, in start():
return new Promise(async (resolve) => {
const assets = await Promise.all(this.loadAssets());
resolve(assets);
});

@AndriySymon AndriySymon changed the title Suboptimal use of Promise Suboptimal use of Promise in client.js Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant