Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to configure flexmark with different options #2183

Open
l3r8yJ opened this issue Jun 21, 2024 · 2 comments · May be fixed by #2280
Open

Ability to configure flexmark with different options #2183

l3r8yJ opened this issue Jun 21, 2024 · 2 comments · May be fixed by #2280
Labels
enhancement

Comments

@l3r8yJ
Copy link

l3r8yJ commented Jun 21, 2024

Current gradle plugin does not allow to configure flexmark with these options
liblit added a commit to liblit/WALA that referenced this issue Jul 21, 2024
@liblit
Add a Markdown linter to check validation tasks
8aba575 
I would rather use Spotless for these checks, for consistency with other
format checkers that we already use.  Spotless supports Markdown via
flexmark, but unfortunately [Spotless does not provide access to any of
flexmark's configuration
options](diffplug/spotless#2183).  That would
leave us with a Markdown linter that is too lenient for my tastes.  For
example, [Spotless's flexmark configuration does not even restrict
maximum line length](diffplug/spotless#2167).

Implements wala#818.
liblit added a commit to liblit/WALA that referenced this issue Jul 21, 2024
@liblit
Add a Markdown linter to check validation tasks
e7c4c94 
I would rather use Spotless for these checks, for consistency with other
format checkers that we already use.  [Spotless supports Markdown via
flexmark](https://github.com/diffplug/spotless/tree/main/plugin-gradle#flexmark),
but unfortunately [Spotless does not provide access to any of flexmark's
configuration
options](diffplug/spotless#2183).  That would
leave us with a Markdown linter that is too lenient for my tastes.  For
example, [Spotless's flexmark configuration does not even restrict
maximum line length](diffplug/spotless#2167).

Resolves wala#818.
@liblit liblit mentioned this issue Jul 21, 2024
Merged
liblit added a commit to wala/WALA that referenced this issue Jul 21, 2024
@liblit
Add a Markdown linter to check validation tasks
202ca3c 
I would rather use Spotless for these checks, for consistency with other
format checkers that we already use.  [Spotless supports Markdown via
flexmark](https://github.com/diffplug/spotless/tree/main/plugin-gradle#flexmark),
but unfortunately [Spotless does not provide access to any of flexmark's
configuration
options](diffplug/spotless#2183).  That would
leave us with a Markdown linter that is too lenient for my tastes.  For
example, [Spotless's flexmark configuration does not even restrict
maximum line length](diffplug/spotless#2167).

Resolves #818.
@Hisoka-X
Copy link

+1

@l3r8yJ
Copy link
Author

l3r8yJ commented Sep 27, 2024

@nedtwigg I can try to implement this, if you don't mind you can assign it to me

l3r8yJ added a commit to l3r8yJ/spotless that referenced this issue Sep 27, 2024
@l3r8yJ
feat(diffplug#2183): flexmark configuration support
6ff2c63
@l3r8yJ l3r8yJ linked a pull request Sep 27, 2024 that will close this issue
Open
l3r8yJ added a commit to l3r8yJ/spotless that referenced this issue Sep 27, 2024
@l3r8yJ
chore(diffplug#2183): transient variable
d5949fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#2183): flexmark configuration support l3r8yJ/spotless
3 participants
@nedtwigg @Hisoka-X @l3r8yJ