Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to Django core team #1686

Closed
bmispelon opened this issue Oct 23, 2024 · 2 comments
Closed

Remove reference to Django core team #1686

bmispelon opened this issue Oct 23, 2024 · 2 comments
Labels

Comments

@bmispelon
Copy link
Member

While reviewing #1672 I noticed that there was a page still referencing the Django core team:

sent to the DSF, the Django core team, and the Django community for comment.

The Django core team was dissolved a while back, so the text of this page and any others (git grep -i "core team" seems to yield other files too) should be updated.

@ontowhee
Copy link
Contributor

Running the grep command above returned the following:

djangoproject/templates/conduct/changes.html:    sent to the DSF, the Django core team, and the Django community for comment.
djangoproject/templates/conduct/changes.html:      a core dev vote</a> for the core team).
djangoproject/templates/diversity/changes.html:    sent to the DSF, the Django core team, and the Django community for comment.
djangoproject/templates/diversity/changes.html:      a core dev vote</a> for the core team).
djangoproject/templates/foundation/coreawardcohort_list.html:{% block og_description %}{% translate "Former Django Core Team dissolved on March 12, 2020." %}{% endblock %}

Looks like the only valid line is the one in coreawardcohort_list.html. I also looked at diversity/changes.html and conduct/changes.html, and the content look similar between those two files.

Is there a phrase that should be used to replace of "core team", or should "core team" be removed? I'm happy to make these changes, if that helps.

@thibaudcolas
Copy link
Member

Thank you both for reporting and investigating! Historical mentions are fine. For the two sent to the DSF, the Django core team,, I would recommend removing the "the Django core team" mentions. The alternative would be to switch to the Steering Council but it’s not their prerogative to review code of conduct changes.

For further context on the rationale for the rewriting, see DEP PR #95, and linked other PRs updating the DEPs terminology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants