Skip to content

FifoPlayer: Make functions static #13603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Apr 28, 2025

No description provided.

@sepalani
Copy link
Contributor

sepalani commented Apr 28, 2025

@tygyh
IMHO, I highly suggest that you stop opening (more) PRs in areas where it doesn't seem you're comfortable with. Especially, if it doesn't provide much value. The more PRs you open, the more likely you will have to deal with (merge/rebase) conflicts. On top of that, it might slow us down in the reviewing process (especially if you need to fix those conflicts multiple times).

Currently more than 10% of the open PRs are yours, see:
https://github.com/dolphin-emu/dolphin/issues?q=is%3Apr+is%3Aopen+author%3Atygyh

Here are suggestions of things you might want to focus on:

  • Closing the PRs you opened that are: obsolete or don't make sense anymore.
  • Changing incomplete PRs to draft if you still plan to work on them but they aren't currently ready (i.e. in a mergeable state).
  • Updating the PRs you have conflicts with so they can get reviewed/merged.
  • Addressing reviews in your existing PRs so they can reach a mergeable state.

Feel free to ping/remind us, if it's taking too long for some interesting PRs that were properly reviewed/approved to get merged. For instance, I'm think of #12938 which sounds like a nice change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants