Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong System.Text.Json dependency in dotnet-watch #44811

Closed
fmulero opened this issue Nov 12, 2024 · 1 comment
Closed

Wrong System.Text.Json dependency in dotnet-watch #44811

fmulero opened this issue Nov 12, 2024 · 1 comment
Labels
Area-Infrastructure untriaged Request triage from a team member

Comments

@fmulero
Copy link

fmulero commented Nov 12, 2024

Description

The dotnet-watch module available in the latest SDK releases published for version 6 and 8 the download page seems to use an old System.Text.Json version.

How to reproduce it

$ wget -q https://dotnetcli.azureedge.net/dotnet/Sdk/6.0.427/dotnet-sdk-6.0.427-linux-x64.tar.gz
$ mkdir dotnet-sdk
$ tar -xzf dotnet-sdk-6.0.427-linux-x64.tar.gz -C dotnet-sdk
$ grep -r "System.Text.Json/6.0.0" dotnet-sdk
dotnet-sdk/sdk/6.0.427/DotnetTools/dotnet-watch/6.0.427-servicing.24468.28/tools/net6.0/any/dotnet-watch.deps.json:      "System.Text.Json/6.0.0": {
dotnet-sdk/sdk/6.0.427/DotnetTools/dotnet-watch/6.0.427-servicing.24468.28/tools/net6.0/any/dotnet-watch.deps.json:    "System.Text.Json/6.0.0": {
dotnet-sdk/sdk/6.0.427/dotnet-watch.deps.json:      "System.Text.Json/6.0.0": {
dotnet-sdk/sdk/6.0.427/dotnet-watch.deps.json:    "System.Text.Json/6.0.0": {

Additional info

MSBuild and other modules are using version 6.0.10. This is probably related with CVE-2024-43485

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 12, 2024
@marcpopMSFT
Copy link
Member

Thanks for reporting this. Unfortunately, this came too late for the November release and .NET 6 is now out of support. Note that the 6.0.0 version only shows up in the deps.json but is not installed. Instead, watch will use the version from the shared framework when it runs so this is a known class of false positives.

@marcpopMSFT marcpopMSFT closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

2 participants