[core] Fetch should always end up in a callback even when response is empty

Author: pajama-coder

src/fetch.cpp

@@ -55,9 +55,7 @@ void Fetch::Receiver::process(Event *evt) {
       m_body->push(*data);
     }
   } else if (evt->is<MessageEnd>() || evt->is<StreamEnd>()) {
-    if (m_body) {
-      m_fetch->on_response(m_head, m_body);
-    }
+    m_fetch->on_response(m_head, m_body);
     m_head = nullptr;
     m_body = nullptr;
   }

src/main.cpp

@@ -277,19 +277,21 @@ class StatusReporter : public PeriodicJob {
       m_url->path(),
       m_headers,
       Data::make(std::move(buffer)),
-      [=](http::ResponseHead *head, Data *body) {
+      [=](http::ResponseHead *head, Data *) {
         m_local_ip = m_fetch->outbound()->local_address()->str();
 
+        auto status = head ? head->status : 0;
+
         // "206 Partial Content" is used by a "smart" repo
         // to indicate that subsequent metric reports can be incremental
-        if (head->status != 206) {
+        if (status != 206) {
           m_initial_metrics = true;
         }
 
         Log::debug(
           Log::CODEBASE,
           "[codebase] Sent status report in %dms (size = %d, response = %d)",
-          int(utils::now() - time), size, head->status
+          int(utils::now() - time), size, status
         );
       }
     );