Skip to content

Commit b36b28d

Browse files
authored
Merge pull request #206 from nixff/pr-fix-image-pipy-version
[ci] fix pipy version string in docker image
2 parents ba28e1d + 54ac6d6 commit b36b28d

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

Dockerfile

+3-6
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,8 @@ ENV pkg_bindir ${pkg_prefix}/bin
77
ENV CXX clang++
88
ENV CC clang
99

10-
ARG VERSION
11-
ENV VERSION=${VERSION}
12-
13-
ARG REVISION
14-
ENV REVISION=${REVISION}
10+
ARG COMMIT_TAG
11+
ENV CI_COMMIT_TAG=${COMMIT_TAG}
1512

1613
ARG COMMIT_ID
1714
ENV CI_COMMIT_SHA=${COMMIT_ID}
@@ -40,7 +37,7 @@ RUN rm -fr pipy/build \
4037
&& mkdir pipy/build \
4138
&& cd pipy/build \
4239
&& export CI_COMMIT_SHA \
43-
&& export CI_COMMIT_TAG=${VERSION}-${REVISION} \
40+
&& export CI_COMMIT_TAG \
4441
&& export CI_COMMIT_DATE \
4542
&& cmake -DPIPY_GUI=${PIPY_GUI} -DPIPY_STATIC=${PIPY_STATIC} -DPIPY_CODEBASES=${PIPY_GUI} -DCMAKE_BUILD_TYPE=${BUILD_TYPE} .. \
4643
&& make -j$(getconf _NPROCESSORS_ONLN) \

build.sh

+1-2
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,7 @@ if $BUILD_CONTAINER; then
265265
echo "Build image ${IMAGE}:$IMAGE_TAG"
266266
sudo docker build --rm -t ${IMAGE}:$IMAGE_TAG \
267267
--network=host \
268-
--build-arg VERSION=$VERSION \
269-
--build-arg REVISION=$REVISION \
268+
--build-arg COMMIT_TAG=$RELEASE_VERSION \
270269
--build-arg COMMIT_ID=$COMMIT_ID \
271270
--build-arg COMMIT_DATE="$COMMIT_DATE" \
272271
--build-arg PIPY_GUI="$PIPY_GUI" \

multi_arch_images_build.sh

+1-2
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,7 @@ for arch in "${ARCHS[@]}"; do
111111
# 构建镜像
112112
docker buildx build --platform $arch -t ${IMAGE}:${IMAGE_TAG}-$arch_name \
113113
--network=host \
114-
--build-arg VERSION=$VERSION \
115-
--build-arg REVISION=$REVISION \
114+
--build-arg COMMIT_TAG=$RELEASE_VERSION \
116115
--build-arg COMMIT_ID=$COMMIT_ID \
117116
--build-arg COMMIT_DATE="$COMMIT_DATE" \
118117
--build-arg PIPY_GUI="$PIPY_GUI" \

0 commit comments

Comments
 (0)