Skip to content

images embedded in the READMEs need to be re-uploaded for this repo #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexlnkp opened this issue Jun 9, 2024 · 2 comments
Open
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@alexlnkp
Copy link
Contributor

alexlnkp commented Jun 9, 2024

the images embedded in the README on the main branch point to RVC-Boss' repo, thus they work.
On dev branch however, the images URLs point to fumiami/Retrieval-based-Voice-Conversion-WebUI , and since the original images were never uploaded to this repo - the images could not be resolved

easily fixable by downloading original images / remaking the original images and then drag n dropping them somewhere in the text so they get uploaded. then they will be uploaded under a new link which can be used in the READMEs.

@fumiama fumiama added the documentation Improvements or additions to documentation label Jun 9, 2024
@alexlnkp
Copy link
Contributor Author

A small correction: Looks like the images that are embedded in the README are HEAVILY outdated. The Gradio UI used in one of them is around 200 commits behind, so re-doing the screenshots from scratch seems like a better solution

@fumiama
Copy link
Owner

fumiama commented Jun 12, 2024

Yes, that's what I will do after the refactoring.

@fumiama fumiama self-assigned this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants