-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Perl commands to upcoming changes in MSYS2? Or drop Perl from Git for Windows? #5393
Comments
I appreciate I haven't contributed for a while, but I did (and hopefully will) use I can see the maintenance benefit of dropping all that other clutter but, as noted, ..
|
Is there a Perl version you can easily download? You'd likely have to put in some effort to make Or maybe you can switch to using regular MSYS2 (I do hope that we're already in a place that is relatively close to MSYS2 being able to consume
GitGitGadget. Although I have to admit that that project probably needs more engagement from the community, especially development-wise, if it is to be viable for the long term.
I hate to be the one to tell you @PhilipOakley, but you're not a big name in the Linux world, and therefore they wouldn't keep the tool around just for you. As it were, though, As for Git for Windows, that's a different story. I am totally willing to abandon support for that if that is the only tool requiring a full Perl and then some modules. |
As I documented in msys2/MSYS2-packages#5177 (comment), Perl will soon be reporting
cygwin
instead ofmsys
when asking$^O
for the operating system, and Git for Windows will have to adjust a couple of lines:git cvsexportcommit
: https://github.com/git-for-windows/git/blob/v2.47.1.windows.2/git-cvsexportcommit.perl#L40git send-email
: https://github.com/git-for-windows/git/blob/v2.47.1.windows.2/git-send-email.perl#L1486git svn
: https://github.com/git-for-windows/git/blob/v2.47.1.windows.2/git-svn.perl#L68Git for Windows' installers already skip
cvsexportcommit
(among other remote helpers targeting the long-forgotten source code management tools CVS and Arch, remote helpers that upstream Git continues to carry probably only for the sole reason that it would take work to remove them, especially the tedious sort of work that is convincing the core Git developers on the Git mailing list, where even one single person using a feature might well prevent said feature from being deprecated as long as said user is a big name in the Linux world). Therefore my current thinking is that droppingcvsexportcommit
(along with the rest of the CVS/Arch stuff) from Git for Windows is a better course of action than actually patching the code.As for
git svn
: This might actually serve as a fine opportunity to drop (or at least deprecate)git svn
support from Git for Windows. I suspect that it has been broken for a long time already, git-for-windows/MSYS2-packages#58 being my attempt to fix those breakages, and the fact that nobody has complained in almost 2.5 years since I opened that PR (and the fact that the breakage probably existed way longer than that and I only noticed when Subversion's regression tests failed in a local build) is highly indicative that continuing work on that Pull Request would be a lot of love's labor lost.While we're already on the train of thought to deprecate parts of Git for Windows that require a lot of work for little gain, let's also have a long and hard look at Perl itself. The last two major version upgrades of Perl required me to spend quite a lot of time, and the most recent one failed somewhere, forcing me to postpone the upgrade, with Perl v5.40.1 swooping in before I could even take a look at the problems with v5.40.0.
Therefore, I could imagine that a bold (and potentially correct) move would be to also drop support for
git send-email
from Git for Windows, which would allow Git for Windows to stop shipping (and thus, building) Perl altogether:The text was updated successfully, but these errors were encountered: