Skip to content

support for namespaced Path Elements #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hellt opened this issue Oct 25, 2020 · 3 comments
Open

support for namespaced Path Elements #244

hellt opened this issue Oct 25, 2020 · 3 comments
Labels

Comments

@hellt
Copy link

hellt commented Oct 25, 2020

Hi all,
in ParseElem the code doesn't allow for a pathElem to have a : char inside of it.

I wonder if this should be allowed to make the path to look life follows: /root/ns:leaf. Some vendors use namespaced paths in their gNMI implementations, and I am not sure if this violates the gNMI spec or not.

@robshakir do you have an opinion if the gNMI paths like /root/ns:leaf are valid and should be supported?

@hellt
Copy link
Author

hellt commented Nov 18, 2020

Hi, bumping
any opinions on this?

@samribeiro
Copy link
Member

Hi @hellt, I am not sure about this myself. I dont see any mention of it in the gNMI documentation:
https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-path-conventions.md

Perhaps opening an issue in https://github.com/openconfig/public asking for clarification is a better approach?

@hellt
Copy link
Author

hellt commented Nov 19, 2020

Thanks for commenting, @samribeiro

I am not sure if that has to be clarified with OC group. The : is not restricted by the very same path conventions document.

Also in the reference gnmi_cli client the team uses another parsing approach - https://github.com/openconfig/gnmi/blob/master/cmd/gnmi_cli/gnmi_cli.go#L310
https://github.com/openconfig/gnmi/blob/d2b4e6a45802a75b3571a627519cae85a197fdda/client/gnmi/client.go#L255

I will check that method.

Feel free to close this issue if you decide not to account for : in paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants