Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print: breaking long lines and general compatibility with prettier #3230

Open
IvanGoncharov opened this issue Aug 11, 2021 · 1 comment
Open

print: breaking long lines and general compatibility with prettier #3230

IvanGoncharov opened this issue Aug 11, 2021 · 1 comment
Labels
enhancement
Milestone
post-16.0.0

Comments

@IvanGoncharov
Copy link
Member

Currently, Prettier doing a way better job at formating GraphQL documents than our own print we should learn more on how they handle the different cases and copy everything that makes sense.
Splitting long lines would be a good first starting point.

Inspired by #1557
@IvanGoncharov IvanGoncharov added this to the post-16.0.0 milestone Aug 11, 2021
@IvanGoncharov IvanGoncharov mentioned this issue Aug 11, 2021
Closed
@yaacovCR
Copy link
Contributor

@mjmahone in #1799 argues that print should stay as performant as possible, and separate prettyPrint should print prettily

@saihaj saihaj mentioned this issue Jun 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
post-16.0.0
Development

No branches or pull requests
2 participants
@yaacovCR @IvanGoncharov