Skip to content

Water barrier cleanup required #5081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
imagico opened this issue Mar 24, 2025 · 0 comments
Open
2 tasks

Water barrier cleanup required #5081

imagico opened this issue Mar 24, 2025 · 0 comments

Comments

@imagico
Copy link
Collaborator

imagico commented Mar 24, 2025

Rendering of water barriers (dam, weir, lock_gate) is quite a mess at the moment with irritating and confusing discrepancies between queries, cartocss symbol code and labels.

Mapper consensus seems to be that

  • waterway=dam can be mapped with either nodes, linear ways and polygons
  • waterway=weir should be mapped with either nodes or linear ways
  • waterway=lock_gate should be mapped with either nodes or linear ways

Hence the following changes should be made:

  • remove label rendering for waterway=weir polygons - see here. This is unintended - hence a bug.
  • remove waterway=weir and waterway=lock_gate from the water-barriers-poly layer query.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant