Skip to content

Commit bff369a

Browse files
committed
Update Node Versions (for tests)
- Move all test to a single file - test on Node 20, 22 and 24 - on Windows and Ubuntu - Sort `package.json` (with VS Code extension of this https://www.npmjs.com/package/sort-package-json)
1 parent d833efb commit bff369a

File tree

6 files changed

+29
-56
lines changed

6 files changed

+29
-56
lines changed

.github/workflows/publish.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
- name: Setup Node
4747
uses: actions/setup-node@v4
4848
with:
49-
node-version: 18
49+
node-version: 20
5050
registry-url: https://registry.npmjs.org/
5151
- name: publish npm
5252
run: npm publish

.github/workflows/test-windows.yml

-35
This file was deleted.

.github/workflows/test.yml

+8-2
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,22 @@ on:
55
branches: [main]
66
pull_request:
77
branches: [main]
8+
workflow_dispatch:
89

910
permissions:
1011
contents: read
1112

1213
jobs:
1314
build:
14-
runs-on: ubuntu-latest
15+
runs-on: ${{ matrix.os }}
1516
strategy:
1617
matrix:
17-
node-version: [18.x, 20.x]
18+
node-version:
19+
- 20
20+
- 22
21+
- 24
22+
os: [ubuntu-latest, windows-latest]
23+
1824
steps:
1925
- name: Get npm cache directory
2026
id: npm-cache

docs/about-this-repo.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ Our branch protection rules are as follows:
5151
- In addition to the PR and approving reviewer, we require three status checks
5252
to pass before code can be merged
5353
_ Build with Node 20
54-
_ Build with Node 18
54+
_ Build with Node 22
55+
_ Build with Node 24
5556
- We _allow_ force pushes for project admins. While force pushes can create
5657
some head scratching moments for people who have cloned the repo and update
5758
before and after the force push, the ability to clean up the `HEAD` of a

package-lock.json

+1-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+17-15
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,28 @@
11
{
22
"name": "html5-boilerplate",
33
"version": "9.0.1",
4-
"homepage": "https://html5boilerplate.com/",
5-
"license": "MIT",
64
"description": "A professional front-end template for building fast, robust, and adaptable web apps or sites.",
75
"keywords": [
86
"h5bp",
97
"template",
108
"front-end"
119
],
10+
"homepage": "https://html5boilerplate.com/",
11+
"bugs": {
12+
"url": "https://github.com/h5bp/html5-boilerplate/issues"
13+
},
1214
"repository": {
1315
"type": "git",
1416
"url": "https://github.com/h5bp/html5-boilerplate.git"
1517
},
16-
"bugs": {
17-
"url": "https://github.com/h5bp/html5-boilerplate/issues"
18-
},
18+
"license": "MIT",
19+
"files": [
20+
"CHANGELOG.md",
21+
"LICENSE.txt",
22+
"package.json",
23+
"dist/",
24+
"README.md"
25+
],
1926
"scripts": {
2027
"build": "gulp build",
2128
"prettier": "prettier --write ./**/*.{js,json,md,mjs,yml}",
@@ -39,8 +46,10 @@
3946
"strip-json-comments": "^5.0.1"
4047
},
4148
"engines": {
42-
"node": ">=18",
43-
"npm": ">=10"
49+
"node": ">=20"
50+
},
51+
"volta": {
52+
"node": "20.19.1"
4453
},
4554
"h5bp-configs": {
4655
"directories": {
@@ -49,12 +58,5 @@
4958
"src": "src",
5059
"test": "test"
5160
}
52-
},
53-
"files": [
54-
"CHANGELOG.md",
55-
"LICENSE.txt",
56-
"package.json",
57-
"dist/",
58-
"README.md"
59-
]
61+
}
6062
}

0 commit comments

Comments
 (0)