You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ResolveEvent that is returned during buffering doesn't have the content which would otherwise always be available with the caching template (PR #59) and the error is nil. This breaks with the other return semantics where it either returns a meaningful ResolveEvent with content OR returns a empty/default ResolveEvent and an error.
This can be addressed in either direction.
add a method to the template to let the resolver grab the cached content and return a meaningful ResolveEvent (w/ content and NoChange=true).
have it return an error when buffering with the empty/default ResolveEvent (like other errors)
I'm leaning towards option 2 but am not 100% yet.
The text was updated successfully, but these errors were encountered:
eikenb
changed the title
What shold resolver.Run returnt when buffering.. error or content?
What should resolver.Run returnt when buffering.. error or content?
Sep 25, 2021
eikenb
changed the title
What should resolver.Run returnt when buffering.. error or content?
What should resolver.Run return when buffering.. error or content?
Sep 25, 2021
The ResolveEvent that is returned during buffering doesn't have the content which would otherwise always be available with the caching template (PR #59) and the error is nil. This breaks with the other return semantics where it either returns a meaningful ResolveEvent with content OR returns a empty/default ResolveEvent and an error.
This can be addressed in either direction.
I'm leaning towards option 2 but am not 100% yet.
The text was updated successfully, but these errors were encountered: