Skip to content

Require Only One Module #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wbotelhos opened this issue Feb 21, 2025 · 1 comment
Open

Require Only One Module #137

wbotelhos opened this issue Feb 21, 2025 · 1 comment

Comments

@wbotelhos
Copy link

First, thanks for this great gem!

Is there any way to require only ruby-vips? I was thinking that maybe is a good idea do not include both libs, so we don't need to install it on the docker image. If a conditional require dependency is not possible, maybe separates it in two different gems like:

image_processing_vips
image_processing_mini_magick
@janko
Copy link
Owner

janko commented Feb 21, 2025

In the upcoming major version, I will demote MiniMagick and ruby-vips to optional dependencies. This means people will have to add MiniMagick or ruby-vips to their Gemfiles, depending on which backend they want to use.

I will also remove the ImageProcessing::{Vips,MiniMagick} autoload, so that people need to require image_processing/{vips,mini_magick} upfront. I believe dependants like Active Storage are currently relying on the autoloading, which is not good, it needs to be eager loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants