Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-completion when not needed #11

Open
denisbredikhin opened this issue Apr 18, 2018 · 4 comments
Open

Auto-completion when not needed #11

denisbredikhin opened this issue Apr 18, 2018 · 4 comments
Labels

Comments

@denisbredikhin
Copy link

Hello.
If I type following expression:
new[] { 1 }.First(s
and then press =, button, I see following:
new[] { 1 }.First(sbyte=
while in Visual Studio I see
'new[] { 1 }.First(s='
this is because after typing s, item in completion list is selected (in blue), while in VS it is just highlighted with blue border.
Is it something that is possible to fix? Or should be reported to avalon edit?

@jbe2277
Copy link
Owner

jbe2277 commented Apr 19, 2018

Thanks for the feedback. The auto-completion feature of DotNetPad is not that sophisticated than the one of Visual Studio. I know of more similar issues like this one.
Improving the auto-completion feature is much effort so it won't happen soon.

@denisbredikhin
Copy link
Author

And did you already think how to improve it? Can this be done without changing AvalonEdit? If I know more or less what to do, I can try to do it myself and make PR.

@jbe2277
Copy link
Owner

jbe2277 commented Apr 25, 2018

Please note that I do not accept contributions (e.g. PR.) at this time. See CONTRIBUTING.md.
I'm not yet sure how to improve it. But my best guess would be to review the Roslyn API calls.

@denisbredikhin
Copy link
Author

Ok, in case you want to fix it in the future, this is what I've found:
you need to check if CompletionList.SuggestionModeItem is not null, and switch to "suggestion" mode in this case.

@jbe2277 jbe2277 added the bug label Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants