Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle transaction.atomic #41

Open
rooterkyberian opened this issue Oct 31, 2023 · 1 comment
Open

handle transaction.atomic #41

rooterkyberian opened this issue Oct 31, 2023 · 1 comment

Comments

@rooterkyberian
Copy link

Seems the most straight forward thing would to not attempt retries when are in transaction, as that can only lead to some terrible bugs.
@mjurbanski-reef mjurbanski-reef mentioned this issue Nov 6, 2023
Closed
@aebrahimian
Copy link

aebrahimian commented Dec 30, 2023 •
edited
Loading

I think calling self.close() is safer than self.connection = None when the connection is closed (here)
it prevent reconnection when you are in atomic transaction block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rooterkyberian @aebrahimian