Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to Resource #15

Closed
olamy opened this issue Mar 31, 2017 · 4 comments
Closed

Add timeout to Resource #15

olamy opened this issue Mar 31, 2017 · 4 comments

Comments

@olamy
Copy link
Member

olamy commented Mar 31, 2017

per default timeout is 60000. Maybe we could make it configurable at resource level.
@sbordet WDYT?

@sbordet
Copy link
Member

sbordet commented Mar 31, 2017

what kind of timeout ?

@olamy
Copy link
Member Author

olamy commented Apr 1, 2017

the read/response timeout: request.timeout( ). (I would not fail the load but report the timeout in Resource.Info)
WDYT?
PS: Well we probably the connectTimeout as well but in the LoadGenerator.config level.

@sbordet
Copy link
Member

sbordet commented Apr 1, 2017

I'm not sure about this. We typically send a "resource" timeout, meaning the whole tree. Having a per-request/response timeout is fine, but how does it apply to the whole tree ?

Right now there is no timeout, as far as I can see. Where did you get that 60s value ?

@olamy
Copy link
Member Author

olamy commented Apr 2, 2017

Oh correct. I missed the point about Resource can be a whole tree.
I was thinking about timeout at the uri level. Resource("/foo/beer/blabla").timeout(15, TimeUnit.SECONDS) meaning 15s max for request to "/foo/beer/blabla". (so the default 60s)
But I/users can simply read results and decide if it was a timeout or not.
So closing

@olamy olamy closed this as completed Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants