Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ResourceProfile #9

Closed
sbordet opened this issue Feb 20, 2017 · 1 comment
Closed

Remove ResourceProfile #9

sbordet opened this issue Feb 20, 2017 · 1 comment
Assignees
@olamy
Milestone
1.0.0

Comments

@sbordet
Copy link
Member

sbordet commented Feb 20, 2017

We should try to remove ResourceProfile, since it adds very little and bloats the API.

The idea would be that if I have N sibling root resources, they will be children of a Resource that has no URI.
The code could test whether a resource has a null URI, and if it does assume that there is no real resource associated with it, but it is just a parent for its children.
@olamy olamy self-assigned this Feb 20, 2017
olamy added a commit that referenced this issue Feb 21, 2017
@olamy
remove ResourceProfile class to only use Resource #9
bbc1579 
Signed-off-by: olivier lamy <[email protected]>
olamy added a commit that referenced this issue Feb 21, 2017
@olamy
fix issue with path null #9
188a078 
Signed-off-by: olivier lamy <[email protected]>
@olamy
Copy link
Member

olamy commented Feb 21, 2017

done

@olamy olamy closed this as completed Feb 21, 2017
@olamy olamy added this to the 1.0.0 milestone Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olamy olamy

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@olamy @sbordet