Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore boolean attribute treatment from 3.x #504

Open
mgol opened this issue Mar 18, 2024 · 2 comments · May be fixed by #540
Open

Restore boolean attribute treatment from 3.x #504

mgol opened this issue Mar 18, 2024 · 2 comments · May be fixed by #540
Assignees
@mgol
Labels
Has Pull Request
Milestone
3.6.0

Comments

@mgol
Copy link
Member

mgol commented Mar 18, 2024 •
edited
Loading

See jquery/api.jquery.com#1243 & jquery/jquery#5452 for changes planned for 4.0. We should restore special boolean attributes treatment and warn if the setter is used with an unrecognized value. In the getter, warn if the value is different than the lowercased attribute name.

Remember to go through the list of boolean attributes in the spec and exempt any new values (like until-found for the hidden attribute) from such a conversion. New attributes should not be added to the list but any changes in existing ones will need to be accounted for.
@mgol mgol added this to the 3.5.0 milestone Mar 18, 2024
@mgol mgol mentioned this issue Mar 18, 2024
Merged
3 tasks
@mgol mgol self-assigned this Mar 20, 2024
@mgol
Copy link
Member Author

mgol commented Mar 25, 2024

I have this work in progress but I'm pausing it for now to focus on other priorities; I'll return to this before the jQuery 4.0.0 RC.

mgol added a commit to mgol/jquery-migrate that referenced this issue Oct 8, 2024
@mgol
Attributes: Restore boolean attribute & false setter treatment from 3.x
e511899 
Restore & warn against:
* boolean attributes set to something different than their lowercase names
* boolean attributes queried when set to something different than their
  lowercase names
* non-boolean non-ARIA attributes set to `false`

Fixes jquerygh-504
Ref jquery/jquery#5452
Ref jquery/api.jquery.com#1243
@mgol mgol linked a pull request Oct 8, 2024 that will close this issue
Open
@mgol
Copy link
Member Author

mgol commented Oct 8, 2024

PR: #540

mgol added a commit to mgol/jquery-migrate that referenced this issue Oct 15, 2024
@mgol
Attributes: Restore boolean attribute & false setter treatment from 3.x
39ccd8b 
Restore & warn against:
* boolean attributes set to something different than their lowercase names
* boolean attributes queried when set to something different than their
  lowercase names
* non-boolean non-ARIA attributes set to `false`

Fixes jquerygh-504
Ref jquery/jquery#5452
Ref jquery/api.jquery.com#1243
mgol added a commit to mgol/jquery-migrate that referenced this issue Oct 28, 2024
@mgol
Attributes: Restore boolean attribute & false setter treatment from 3.x
65a03af 
Restore & warn against:
* boolean attributes set to something different than their lowercase names
* boolean attributes queried when set to something different than their
  lowercase names
* non-boolean non-ARIA attributes set to `false`

Fixes jquerygh-504
Ref jquery/jquery#5452
Ref jquery/api.jquery.com#1243
mgol added a commit to mgol/jquery-migrate that referenced this issue Oct 29, 2024
@mgol
Attributes: Restore boolean attribute & false setter treatment from 3.x
7872ddd 
Restore & warn against:
* boolean attributes set to something different than their lowercase names
* boolean attributes queried when set to something different than their
  lowercase names
* non-boolean non-ARIA attributes set to `false`

Fixes jquerygh-504
Ref jquery/jquery#5452
Ref jquery/api.jquery.com#1243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgol mgol

Labels
Has Pull Request
Projects
None yet
Milestone
3.6.0
Development

Successfully merging a pull request may close this issue.

Attributes: Restore boolean attribute & false setter treatment from 3.x mgol/jquery-migrate
1 participant
@mgol