-
-
Notifications
You must be signed in to change notification settings - Fork 88
Option to use saved items list #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I added a separate check of the saved items list in the main loop and delay the code with a timeout. It's not great because it can still start too fast but we also don't want to delay too long. An even trigger would be better. I've also begun the framework to support multiple items in the item list but counting them and refreshing/proceeding to add to cart is as for as I've gotten. |
Hey @Spegs21, I can help take a look at this if you need a second pair of eyes on it. I've also noticed that the |
@SebTota I'd welcome the help. I haven't done much with JS so it can take me a bit to figure out how to do some of this stuff. |
Do you want any item in the saved item list to be added to card, or does the name of the item still need to contain the keyword? |
I was planning on checking for the keyword still but we could just limit this to the first item if finds in stock for simplicity. |
I can add the extra check in the title. My code is very similar to yours, I just check the buttons when a change in the DOM has been made rather than using a timeout so it shouldn't be a problem. I did see @kkapuria3 assigned this to himself though so I'm not sure if I should still work on it or not. |
I've heard people may have better luck by adding to the cart from the saved items list.
This seemed like it should be a fairly easy implementation but the page is slow to load so the script runs before the button loads and can't find it.
I tired adding event handlers to wait for the page to load but I could never get the window.onLoad event to fire for the popup, even if I attached an event handler to it.
The text was updated successfully, but these errors were encountered: