Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a filename includes a dot, the extensions property does not work #143

Open
maxweisel opened this issue Sep 7, 2021 · 0 comments
Open

Comments

@maxweisel
Copy link

This is essentially the same bug as #79 but the fix employed doesn't work if the actual filename includes a dot.

The issue is with this line: https://github.com/koajs/send/blob/master/index.js#L100

From looking at it, it really seems like we should drop the regex check altogether, but I don't fully understand why the regex check is there in the first place.

Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant