Skip to content

Social Media Sharing Bugs and Enhancements #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
keithmifsud opened this issue Apr 23, 2018 · 9 comments
Closed
3 tasks done

Social Media Sharing Bugs and Enhancements #60

keithmifsud opened this issue Apr 23, 2018 · 9 comments
Assignees

Comments

@keithmifsud
Copy link
Contributor

keithmifsud commented Apr 23, 2018

@danielepolencic
Copy link
Contributor

About 90% of the shares comes Twitter. I'd really like to fix this, what can we do?

@keithmifsud
Copy link
Contributor Author

I'll find a way to update the share window so that it displays the text and image preview before tweeting. On it, as we speak.

@keithmifsud keithmifsud reopened this Apr 23, 2018
@keithmifsud
Copy link
Contributor Author

@danielepolencic As it is, when tweeting, the tweet appears like this:

image

Just to make sure we're both on the same issue. Currently, once clicking on the twitter share link, a small window opens like this:
image

Am I right to say that you want it to look like this?
image

If so, Twitter is a bit different (obviously) because of the characters limit and the ability to have hash tags and a twitter username. I assume that we want the @learnk8s as the username? Do you wnat to have automated hashtags generated? If so how should I get these? Add a front-matter property on each article?

@danielepolencic
Copy link
Contributor

I think it would be nice if we could customise the message and tag @learnk8s

@keithmifsud
Copy link
Contributor Author

Yes, the user will be able to change the contents of the text box. Same as they can do now but it will initially be auto-populated with an excerpt and p[ossibly a couple of hashtags.

@keithmifsud
Copy link
Contributor Author

The issue is that an excerpt is already provided by the OG property. What should we add to the contents? This already works as it is, the only missing things are the image and the excerpt inside the share window. Once shared, they are visible on Twitter's timeline.

@danielepolencic
Copy link
Contributor

Oh I see. Perhaps we could have something like "{Title} via @learnk8s"? we know the title is always short enough for a tweet.

@keithmifsud
Copy link
Contributor Author

Okay. I can limit the length using a liquid filter because the new "Web Intent" from Twitter's docs say that if the length is exceeded it won't be automatically cropped out and (although not clear) I assume that the text will simply not be included. Bear in mind that the URL text is included in the limit as it is displayed as part of the tweet.

@danielepolencic
Copy link
Contributor

I think that should be fine for a first release.

@keithmifsud keithmifsud changed the title Twitter share not pulling the image and description from the open graph properties. Social Media Sharing Bugs and Enhancements Apr 24, 2018
keithmifsud added a commit that referenced this issue Apr 25, 2018
keithmifsud added a commit that referenced this issue Apr 25, 2018
keithmifsud added a commit that referenced this issue Apr 25, 2018
* V2 of existing blog post.

* Updated the content as per PR #GH-45

* Several fixes as per PR review

* Added a reverse loop to blog list

* diagrams and illustrations

* included resources and guideline

* tweaked title

* updated opacity

* GH-60 Developed a twitter share script. Not refactored YET!

* GH-60 Refactored the JS for opening the share window.

* GH-60 Reafctored the Twitter JS

* GH-60 Changed the share links to use the page.url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants