Is Excluding Individual Files Broken?

[sekyondaMeta]

Running the workflow below does not seem to exclude the .png file. I have tried different permutations and combinations of adding the regex, but nothing seems to work. Any ideas would be greatly appreciated.

Workflow

name: link check on PR

on:
  pull_request:
    branches: [main]

jobs:
  linkChecker:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v4
        with:
          fetch-depth: 1

      - name: Get Changed Files
        id: changed-files
        uses: tj-actions/changed-files@v41

      - name: Check for Skip Label
        id: skip-label
        uses: actions/github-script@v6
        with:
          script: |
            const labels = await github.rest.issues.listLabelsOnIssue({
              owner: context.repo.owner,
              repo: context.repo.repo,
              issue_number: context.issue.number
            });
            return labels.data.some(label => label.name === 'skip-link-check');
          
      - name: Check Links
        if: steps.skip-label.outputs.result == 'false'
        uses: lycheeverse/lychee-action@v1
        with:
          args: --exclude '\.(pdf|zip|png|jpg)$' --accept=200,403,429 --base . --verbose --no-progress ${{ steps.changed-files.outputs.all_changed_files }}
          token: ${{ secrets.CUSTOM_TOKEN }}
          fail: true
          
      - name: Skip Message
        if: steps.skip-label.outputs.result == 'true'
        run: echo "Link check was skipped due to the presence of the 'skip-link-check' label."
        
      - name: Suggestions
        if: failure()
        run: |
          echo -e "\nPlease review the links reported in the Check links step above."
          echo -e "If a link is valid but fails due to a CAPTCHA challenge, IP blocking, login requirements, etc., consider adding such links to .lycheeignore file to bypass future checks.\n"
          exit 1

Error message

Run lycheeverse/lychee-action@v1
Run # Cleanup artifacts from previous run in case it crashed
lychee
Run /home/runner/work/_actions/lycheeverse/lychee-action/v1/entrypoint.sh
Error: Cannot read input content from file recipes_source/customaddandround.png`

`Caused by:
    stream did not contain valid UTF-8`

[mre]

The key issue is this:

lychee --exclude '\.(pdf|zip|png|jpg)$' --accept=200,403,429 --base . --verbose --no-progress .

--exclude for URLs, but you want to exclude paths. To be more precise, you want to exclude PNG files from the list of changed files. You can exclude paths with --exclude-path.

lychee --exclude-path "*.png"

However, I think that's broken at the moment. 😕 At least I couldn't get it to work on my local machine.

More info:

• https://lychee.cli.rs/recipes/excluding-paths/
• https://lychee.cli.rs/recipes/excluding-links/

[sekyondaMeta]

@mre That makes sense and thanks for taking a look at this. Will make the change and keep an eye out for any changes if/when the bug is fixed.

[andrewvaughan]

Is excluding files broken altogether? I was about to make a similar post that this wasn't skipping files:

exclude_path = [
    "*.mdx",
    "node_modules"
]

[sekyondaMeta]

Is excluding files broken altogether? I was about to make a similar post that this wasn't skipping files:

exclude_path = [
"*.mdx",
"node_modules"
]

For my use case it seems I can exclude an entire folder using exclude_path but have not been able to target specific file types using exclude_path