Skip to content

Better handling if the user didn't grant notification permission #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxwai opened this issue Dec 9, 2024 · 3 comments
Open

Better handling if the user didn't grant notification permission #18

maxwai opened this issue Dec 9, 2024 · 3 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@maxwai
Copy link
Owner

maxwai commented Dec 9, 2024

Currently, the com.maxwai.nclientv3.settings.NotificationSettings Class just ignores it if the permission to send notifications isn't given. I also can't actually find where the app requests the initial Notification permission (maybe this is from Android itself??).

It needs to be discussed what the better way is, either to ignore it and expect the user to enable it in the settings or ask once per session if it is not given, or a middle ground, open for suggestions.

@maxwai maxwai added help wanted Extra attention is needed question Further information is requested labels Dec 9, 2024
@MortusMg
Copy link

What will it be needed for?
I use this app for a couple of years but didn't receive a notification even once.

@maxwai
Copy link
Owner Author

maxwai commented Dec 15, 2024

What will it be needed for? I use this app for a couple of years but didn't receive a notification even once.

It (should) happen when you download a gallery.

@MortusMg
Copy link

Oh, I didn’t know that! I’ve never tried to download before.

Since a lot of people tend to skip app permission requests, I can think of three ways to handle it:

Explain First: Show a quick message explaining why the notification permission is needed before asking for it. If the user ignores it, just move on and don’t ask again.

Ask Every Time: Request the permission every time the user tries to download, until approved.

A Mix of Both: Ask for the permission after installation. If they ignore it, ask again with a brief explanation the first time they try to download something. If they still ignore it, just forget about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants